test(hash): add unit tests for Hash, Hash determinism, and Md5Hex edg…#5469
Merged
kevwan merged 1 commit intozeromicro:masterfrom Mar 15, 2026
Merged
test(hash): add unit tests for Hash, Hash determinism, and Md5Hex edg…#5469kevwan merged 1 commit intozeromicro:masterfrom
kevwan merged 1 commit intozeromicro:masterfrom
Conversation
kevwan
force-pushed
the
test-hash-unit-tests
branch
from
5892f11 to
69521c8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
kevwan
approved these changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Hash()function incore/hash/hash.go(murmur3 wrapper) has no dedicated unit test. OnlyMd5()andMd5Hex()are directly tested. WhileHash()is exercised indirectly throughconsistenthash_test.go, the function itself lacks isolated coverage.Solution
Added 4 new test cases to
core/hash/hash_test.go:TestHashHash()returns a non-zero value for non-empty inputTestHash_DeterministicTestHash_EmptyHash()does not panic on empty byte sliceTestMd5Hex_EmptyMd5Hex()returns a valid 32-char hex string for empty inputImpact
Testing performed
Files changed
core/hash/hash_test.go— added 4 test functions